| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: json(b)_to_tsvector with numeric values |
| Date: | 2018-04-07 16:07:28 |
| Message-ID: | CA+q6zcW5p8i7+0Lv01EUZBaih_nRk_bu91SZM_NHWwtVhwhTeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 7 April 2018 at 17:09, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>>> See workable sketch for parsing jsonb flags and new worker variant.
>>
>>
>> Yep, thanks for the sketch. Here is the new version of patch, does it look
>> close to what you have in mind?
>
>
> Patch looks good except error messaging, you took it directly from sketch
> where I didn't spend time for it. Please, improve. elog() should be used
> only for impossible error, whereas user input could contins mistakes.
I assume what you mean is that for user input errors we need to use ereport.
Indeed, thanks for noticing. I've replaced all elog except the last one, since
it actually describes an impossible situation, when we started to read an
array, but ended up having something else instead WJB_END_ARRAY.
| Attachment | Content-Type | Size |
|---|---|---|
| jsonb_to_tsvector_numeric_v5.patch | application/octet-stream | 36.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-04-07 16:09:46 | Re: [HACKERS] [PATCH] Incremental sort |
| Previous Message | Tom Lane | 2018-04-07 16:06:52 | Re: [HACKERS] [PATCH] Incremental sort |