Re: json(b)_to_tsvector with numeric values

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Oleg Bartunov <obartunov(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: json(b)_to_tsvector with numeric values
Date: 2018-04-07 18:05:21
Message-ID: 064de98a-23e2-01f9-13c2-2f518aaa3089@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you, pushed with some editorization

Dmitry Dolgov wrote:
>> On 7 April 2018 at 17:09, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>>>> See workable sketch for parsing jsonb flags and new worker variant.
>>>
>>>
>>> Yep, thanks for the sketch. Here is the new version of patch, does it look
>>> close to what you have in mind?
>>
>>
>> Patch looks good except error messaging, you took it directly from sketch
>> where I didn't spend time for it. Please, improve. elog() should be used
>> only for impossible error, whereas user input could contins mistakes.
>
> I assume what you mean is that for user input errors we need to use ereport.
> Indeed, thanks for noticing. I've replaced all elog except the last one, since
> it actually describes an impossible situation, when we started to read an
> array, but ended up having something else instead WJB_END_ARRAY.
>

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-04-07 18:07:05 Re: Bring atomic flag fallback up to snuff
Previous Message Andres Freund 2018-04-07 17:58:40 Re: pgsql: New files for MERGE