| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, bossartn(at)amazon(dot)com |
| Subject: | Re: Make description of heap records more talkative for flags |
| Date: | 2018-11-09 15:23:57 |
| Message-ID: | CA+q6zcUD6oM0OAgiz6VbFYJSasjq2B5afTU8mdO2iDio+-3ZSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Fri, 15 Jun 2018 at 17:09, Nathan Bossart <bossartn(at)amazon(dot)com> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: not tested
>
> - appendStringInfo(buf, "off %u", xlrec->offnum);
> + appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
> + xlrec->flags);
>
> Can we add "0x" before the flags so that it is abundantly clear it's a
> hex value?
This thread is being inactive for quite some time. As far as I understand, the
agreement was to add it in the PG12 commit cycle, so probably it's a good time
to do so. Any plans about that?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2018-11-09 15:50:05 | Re: jsonpath |
| Previous Message | Adam Berlin | 2018-11-09 15:14:00 | Re: Add extension options to control TAP and isolation tests |