The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
- appendStringInfo(buf, "off %u", xlrec->offnum);
+ appendStringInfo(buf, "off %u flags %02X", xlrec->offnum,
+ xlrec->flags);
Can we add "0x" before the flags so that it is abundantly clear it's a
hex value?
Nathan