Re: Size vs size_t or, um, PgSize?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Yurii Rashkovskii <yrashk(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Size vs size_t or, um, PgSize?
Date: 2023-07-03 19:02:35
Message-ID: CA+hUKGLyLmUph_krxmERxJhwsje7Azb2u9MDanTm9AsdOe=zag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 4, 2023 at 6:46 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 3 Jul 2023, at 20:32, Yurii Rashkovskii <yrashk(at)gmail(dot)com> wrote:
> > If there's a willingness to try this out, I am happy to prepare a patch.
>
> This has been discussed a number of times in the past, and the conclusion from
> last time IIRC was to use size_t for new code and only change the existing
> instances when touched for other reasons to avoid churn.

One such earlier discussion:

https://www.postgresql.org/message-id/flat/CAEepm%3D1eA0vsgA7-2oigKzqg10YeXoPWiS-fCuQRDLwwmgMXag%40mail.gmail.com

I personally wouldn't mind if we just flipped to standard types
everywhere, but I guess it wouldn't help with your problem with
extensions on macOS as you probably also want to target released
branches, not just master/17+. But renaming in the back branches
doesn't sound like something we'd do...

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yurii Rashkovskii 2023-07-03 19:14:00 Re: Size vs size_t or, um, PgSize?
Previous Message Daniel Gustafsson 2023-07-03 18:53:52 Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?