| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Date: | 2022-03-23 21:02:48 |
| Message-ID: | CA+hUKGL5Jjx10bnaV1ZHr3uYzQGeS+47vsbzur3hXPShTKD10g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 24, 2022 at 9:59 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Wed, Mar 23, 2022 at 1:53 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > And therefore I favor defining it to mean that we don't
> > skip any work at all.
>
> But even today DISABLE_PAGE_SKIPPING won't do pruning when we cannot
> acquire a cleanup lock on a page, unless it happens to have XIDs from
> before FreezeLimit (which is probably 50 million XIDs behind
> OldestXmin, the vacuum_freeze_min_age default). I don't see much
> difference.
Yeah, I found it confusing that DISABLE_PAGE_SKIPPING doesn't disable
all page skipping, so 3414099c turned out to be not enough.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-03-23 21:12:27 | Re: [PATCH] Remove workarounds to format [u]int64's |
| Previous Message | Zhihong Yu | 2022-03-23 21:02:10 | Re: ExecRTCheckPerms() and many prunable partitions |