| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Niyas Sait <niyas(dot)sait(at)linaro(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add native windows on arm64 support |
| Date: | 2022-03-24 22:38:44 |
| Message-ID: | CA+hUKGKGZ2crHGDi=zXtjYy9GptUZ99Jtu=w-P_qeaeaP8k7mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 24, 2022 at 2:15 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I think we've generally seen the ASLR issue become less prominent on
> windows. Whether that's because of the silent retries we added, or because
> just about everyone moved to 64bit windows / PG, I don't know. I'd guess both,
> with 64bit being the larger influence.
>
> Wonder if it's worth adding some debug logging to the retry code and stop
> disabling ASLR on 64bit windows... It's imo pretty crazy that we loop up to
> 100 times in internal_forkexec() around CreateProcess() &&
> pgwin32_ReserveSharedMemoryRegion() without, as far as I can see, a single
> debug message.
Yeah. I think we should commit this patch, but decree that
Windows/aarch64 support is experimental only for now. That allows a
build farm animal to be set up. Then we add a bit of extra logging
and see how it does running our test suite over time and learn more.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2022-03-24 22:40:30 | Re: [PATCH] add relation and block-level filtering to pg_waldump |
| Previous Message | Greg Stark | 2022-03-24 22:38:15 | Re: pg_dump new feature: exporting functions only. Bad or good idea ? |