Re: Tests "with" and "alter_table" suffer from name clash

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tests "with" and "alter_table" suffer from name clash
Date: 2021-12-30 04:25:40
Message-ID: CA+hUKGKETERzQfKZBXnK7oMCJ3GucXnnaq1mKQy-nKfq0J5Meg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 30, 2021 at 3:27 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Looks reasonable. We really should avoid using such common
> names for short-lived tables in any case --- it's an invitation
> to trouble. So I'd vote for changing the other use of "test", too.

In fact only REL_10_STABLE had the problem, because commit 2cf8c7aa
already fixed the other instance in later branches. I'd entirely
forgotten that earlier discussion, which apparently didn't quite go
far enough. So I only needed to push the with.sql change. Done.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-12-30 04:50:32 Re: Tests "with" and "alter_table" suffer from name clash
Previous Message Tom Lane 2021-12-30 02:27:09 Re: Tests "with" and "alter_table" suffer from name clash