Re: Tests "with" and "alter_table" suffer from name clash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tests "with" and "alter_table" suffer from name clash
Date: 2021-12-30 02:27:09
Message-ID: 2195664.1640831229@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> With unlucky scheduling you can get a failure like this:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly&dt=2021-12-22%2010%3A51%3A32
> Suggested fix attached.

Looks reasonable. We really should avoid using such common
names for short-lived tables in any case --- it's an invitation
to trouble. So I'd vote for changing the other use of "test", too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-12-30 04:25:40 Re: Tests "with" and "alter_table" suffer from name clash
Previous Message Thomas Munro 2021-12-30 02:12:04 Tests "with" and "alter_table" suffer from name clash