| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2024-07-15 03:26:32 |
| Message-ID: | CA+hUKGK3sB-T+Ao8EBCOu5M1MsCMPnPpNyXuQGkQYHU4WC35eA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 8, 2024 at 2:49 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> what is the scope of the review you seek?
The patch "Refactor tidstore.c memory management." could definitely
use some review. I wasn't sure if that should be proposed in a new
thread of its own, but then the need for it comes from this
streamifying project, so... The basic problem was that we want to
build up a stream of block to be vacuumed (so that we can perform the
I/O combining etc) + some extra data attached to each buffer, in this
case the TID list, but the implementation of tidstore.c in master
would require us to make an extra intermediate copy of the TIDs,
because it keeps overwriting its internal buffer. The proposal here
is to make it so that you can get get a tiny copyable object that can
later be used to retrieve the data into a caller-supplied buffer, so
that tidstore.c's iterator machinery doesn't have to have its own
internal buffer at all, and then calling code can safely queue up a
few of these at once.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-07-15 03:44:48 | Re: race condition when writing pg_control |
| Previous Message | Thomas Munro | 2024-07-15 03:03:06 | Re: s/shm_mq_iovec/struct iovec/ |