From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command. |
Date: | 2021-07-13 11:55:57 |
Message-ID: | CA+hUKGJoVSXU5xFoLUTfbZHLwtJWjnhK9Q3yULM5HL7jVLc8nw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Here's a better patch. I check if there is any declaration at all,
which ancient HPUX should fail based on:
command.c:5062:4: warning: implicit declaration of function 'sigwait'
Then I also check that there isn't an incompatible declaration with
the technique from thread_test.c, which Solaris should fail, based on:
command.c:5062:8: error: too many arguments to function 'sigwait'
A well placed -D_POSIX_PTHREAD_SEMANTICS might allow it work on
Solaris, but I'm not sure if it's OK to do that without other
threading options and I don't have access to test.
Attachment | Content-Type | Size |
---|---|---|
0001-Portability-fixes-for-sigwait.patch | text/x-patch | 8.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-07-13 17:40:27 | Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command. |
Previous Message | Thomas Munro | 2021-07-13 06:43:43 | Re: pgsql: Add PSQL_WATCH_PAGER for psql's \watch command. |