Re: pgsql: pgbench: Refactor thread portability support.

On Wed, Mar 10, 2021 at 8:14 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Mar 10, 2021 at 8:10 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > On Wed, Mar 10, 2021 at 04:52:01AM +0000, Thomas Munro wrote:
> > > pgbench: Refactor thread portability support.
> > >
> > > Instead of maintaining an incomplete emulation of POSIX threads for
> > > Windows, let's use an extremely minimalist macro-based abstraction for
> > > now. A later patch will extend this, without the need to supply more
> > > complicated pthread emulation code. (There may be a need for a more
> > > serious portable thread abstraction in later projects, but this is not
> > > it.)
> >
> > This one is causing a failure in whelk:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2021-03-10%2006%3A41%3A53
> > src/bin/pgbench/pgbench.c(6154): warning C4024: '_beginthreadex' :
> > different types for formal and actual parameter 3 [C:\\buildfarm\\buildenv\\HEAD\\pgsql.build\\pgbench.vcxproj]
>
> Thanks, looking at this and the others.

whelk is complaining about a missing __stdcall (not clear why various
other Windows systems in CI, real life and the BF didn't mind, but I
have an attempt at a fix ready to push soon). lapwing is just a silly
%ld where INT64_FORMAT was wanted, repro'd and fixed here in a -m32
build. I'm now contemplating what's up with hoverfly (some AIX header
problem)...