Regression tests vs SERIALIZABLE

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Regression tests vs SERIALIZABLE
Date: 2021-03-15 04:24:08
Message-ID: CA+hUKGJUaHeK=HLATxF1JOKDjKJVrBKA-zmbPAebOM0Se2FQRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
noticed that select_parallel.sql and write_parallel.sql believe that
(1) the tests are supposed to work with serializable as a default
isolation level, and (2) parallelism would be inhibited by that, so
they'd better use something else explicitly. Here's a patch to update
that second thing in light of commit bb16aba5. I don't think it
matters enough to bother back-patching it.

However, since commit 862ef372d6b, there *is* one test that fails if
you run make installcheck against a cluster running with -c
default_transaction_isolation=serializable: transaction.sql. Is that
a mistake? Is it a goal to be able to run this test suite against all
3 isolation levels?

@@ -1032,7 +1032,7 @@
SHOW transaction_isolation; -- out of transaction block
transaction_isolation
-----------------------
- read committed
+ serializable
(1 row)

Attachment Content-Type Size
0001-Parallel-regression-tests-don-t-need-workaround-for-.patch text/x-patch 3.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-03-15 04:28:44 Re: Change JOIN tutorial to focus more on explicit joins
Previous Message Julien Rouhaud 2021-03-15 03:54:55 Re: pl/pgsql feature request: shorthand for argument and local variable references