| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: consider -Wmissing-variable-declarations |
| Date: | 2024-08-28 03:31:13 |
| Message-ID: | CA+hUKG+YVt5MBD-w0HyHpsGb4U8RNge3DvAbDmOFy_epGhZ2Mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 19, 2024 at 3:02 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > -const char *EAN13_range[][2] = {
> > +static const char *EAN13_range[][2] = {
> > {"000", "019"}, /* GS1 US */
> > {"020", "029"}, /* Restricted distribution (MO defined) */
> > {"030", "039"}, /* GS1 US */
>
> > -const char *ISBN_range[][2] = {
> > +static const char *ISBN_range[][2] = {
> > {"0-00", "0-19"},
> > {"0-200", "0-699"},
> > {"0-7000", "0-8499"},
> > @@ -967,7 +967,7 @@ const char *ISBN_range[][2] = {
> > */
FYI these ones generate -Wunused-variable warnings from headerscheck
on CI, though it doesn't fail the task. Hmm, these aren't really
headers, are they?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-08-28 03:43:43 | Re: Flush pgstats file during checkpoints |
| Previous Message | Richard Guo | 2024-08-28 03:30:45 | Re: Significant Execution Time Difference Between PG13.14 and PG16.4 for Query on information_schema Tables. |