| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Full Hash Join |
| Date: | 2023-04-04 21:53:19 |
| Message-ID: | CA+hUKG+=URUf+ZBxeZ=viY7qj2gUhtQSKJc4PL-Yre_Pux774A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 5, 2023 at 7:37 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> The comment is no longer in sync with the code: this if-test used to
> reject JOIN_FULL and JOIN_RIGHT, and no longer does so, but the comment
> still claims it should. Shouldn't we drop the sentence beginning
> "Similarly"? (I see that there's now one sub-section that still rejects
> such cases, but it no longer seems correct to claim that they're rejected
> overall.)
Yeah, thanks. Done.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-04-04 22:57:27 | Re: Check whether binaries can be released for s390x |
| Previous Message | Imseih (AWS), Sami | 2023-04-04 21:48:17 | Re: [BUG] pg_stat_statements and extended query protocol |