Re: [PATCH] Add a menu option for disabling restoration of previous environment on reconnect

From: Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add a menu option for disabling restoration of previous environment on reconnect
Date: 2014-01-13 00:08:16
Message-ID: CA+gt1Feg8jF+j_ZGiqiPHUCbkfHb3VxLo2MwhKYvxtUsN=2JmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ok can understand that, thanks for the explanation Dave.

Btw, talking about what users need and use - the only sure way to get a
glimpse in there would be to add some kind of voluntary statistics
collection to improve the program, similar to what many bigger projects
like Firefox do. Currently to me it seems that though the name refers to
database administration, people mostly only use it for just quering, and
when looking at the TODO list I see a lot of admin features in planning and
not so many quering UX improvements, so there's a discrepancy there in my
opinion. Have there been any such ideas moving around or is it even
technically possible (with reasonable amount of work) from framework side?

Cheers,
Kaarel

On Thu, Jan 9, 2014 at 10:12 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Wed, Jan 8, 2014 at 10:33 PM, Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com>
> wrote:
> > Oh indeed, missed the attachment somehow, sorry about that.
> >
> > And yes, there's an option already for that. But its on the 'advanced'
> tab
> > with the default being "on" (changing this to "off" wouldn't probably be
> > nice now) meaning couple of extra clicks which in case of dozens of
> servers
> > gets quickly quite annoying.
>
> Use sed on your config file to bulk-disable that option then. I don't
> see a need to complicate the code with this (and potentially follow-on
> options to do the same for other settings) for something that has been
> requested once in 10+ years and is trivial to work around.
>
> I know that sounds harsh, but we have to consider long term
> maintainability of the code, and complexity of the UI for the user.
> Yours is just one checkbox (well, two if we count your folding
> change), but we've had lots of such requests over the years. We can
> really only add those for which there is a clear need, or high demand.
>
> > On Mon, Jan 6, 2014 at 10:00 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> On Mon, Jan 6, 2014 at 7:57 AM, Guillaume Lelarge
> >> <guillaume(at)lelarge(dot)info> wrote:
> >> > On Mon, 2014-01-06 at 09:59 +0530, Ashesh Vashi wrote:
> >> >> Did you forget to attach the patch?
> >> >>
> >> >
> >> > And isn't this already handled in the server's property?
> >>
> >> Yes, it is.
> >>
> >> >> On Mon, Jan 6, 2014 at 3:49 AM, Kaarel Moppel
> >> >> <kaarel(dot)moppel(at)gmail(dot)com>wrote:
> >> >>
> >> >> > Checkbox resides under "Options-> Browser -> UI misc".
> >> >> >
> >> >> > NB! didn't add the embed-xrc generated xrcDialogs.cpp class due to
> >> >> > verbosity, so it needs to executed by the code maintainer.
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >
> >> > --
> >> > Guillaume
> >> > http://blog.guillaume.lelarge.info
> >> > http://www.dalibo.com
> >> >
> >> >
> >> >
> >> > --
> >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
> )
> >> > To make changes to your subscription:
> >> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Kaarel Moppel 2014-01-13 00:15:46 Re: [PATCH] Added a menu option to disable code folding
Previous Message Kaarel Moppel 2014-01-12 23:43:33 Re: [PATCH] fix newly added server being lost when crashing