Re: [PATCH] Add a menu option for disabling restoration of previous environment on reconnect

On Wed, Jan 8, 2014 at 10:33 PM, Kaarel Moppel <kaarel(dot)moppel(at)gmail(dot)com> wrote:
> Oh indeed, missed the attachment somehow, sorry about that.
>
> And yes, there's an option already for that. But its on the 'advanced' tab
> with the default being "on" (changing this to "off" wouldn't probably be
> nice now) meaning couple of extra clicks which in case of dozens of servers
> gets quickly quite annoying.

Use sed on your config file to bulk-disable that option then. I don't
see a need to complicate the code with this (and potentially follow-on
options to do the same for other settings) for something that has been
requested once in 10+ years and is trivial to work around.

I know that sounds harsh, but we have to consider long term
maintainability of the code, and complexity of the UI for the user.
Yours is just one checkbox (well, two if we count your folding
change), but we've had lots of such requests over the years. We can
really only add those for which there is a clear need, or high demand.

> On Mon, Jan 6, 2014 at 10:00 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Mon, Jan 6, 2014 at 7:57 AM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>> > On Mon, 2014-01-06 at 09:59 +0530, Ashesh Vashi wrote:
>> >> Did you forget to attach the patch?
>> >>
>> >
>> > And isn't this already handled in the server's property?
>>
>> Yes, it is.
>>
>> >> On Mon, Jan 6, 2014 at 3:49 AM, Kaarel Moppel
>> >> <kaarel(dot)moppel(at)gmail(dot)com>wrote:
>> >>
>> >> > Checkbox resides under "Options-> Browser -> UI misc".
>> >> >
>> >> > NB! didn't add the embed-xrc generated xrcDialogs.cpp class due to
>> >> > verbosity, so it needs to executed by the code maintainer.
>> >> >
>> >>
>> >>
>> >>
>> >
>> > --
>> > Guillaume
>> > http://blog.guillaume.lelarge.info
>> > http://www.dalibo.com
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company