From: | Jorge Solórzano <jorsol(at)gmail(dot)com> |
---|---|
To: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> |
Cc: | Dave Cramer <pg(at)fastcrypt(dot)com>, Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: Postgis example TestAutoregister is not working due to missing getVersion() from pgjdbc community jar |
Date: | 2017-08-04 18:27:05 |
Message-ID: | CA+cVU8Nn5cdzg-PU3JpBtczmdh2Fa-2+PdBZUOCpksAd3MizhA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Please don't remove the deprecated annotation, postgis-jdbc should have not
used that method in first place, and it's just a convenience method that
should not be public.
It's ok to have that method forever, but the deprecated annotation is a
clear sign that it should not be used, for future use.
I get the problem with current getMajor/MinorVersion, but isn't more
appropriate to redirect anyone directly to org.postgresql.util.DriverInfo
for those that want "special" formating? (here with a big asterisk that
this class should not be for "public use").
Jorge Solórzano
On Fri, Aug 4, 2017 at 11:42 AM, Vladimir Sitnikov <
sitnikov(dot)vladimir(at)gmail(dot)com> wrote:
> >If we are going to make methods public then we are sort of publishing a
> contract and we can't just go about removing them.
>
> So we should invent the contract.
>
> The "problem" with current Driver#getMajorVersion/getMinorVersion is the
> methods return just int, and they do not have a room for a full version
> (e.g. JRE variation).
>
> Vladimir
>
From | Date | Subject | |
---|---|---|---|
Next Message | Jean Dannemann | 2017-08-08 11:24:30 | Chage driver locale. |
Previous Message | Vladimir Sitnikov | 2017-08-04 17:42:19 | Re: Postgis example TestAutoregister is not working due to missing getVersion() from pgjdbc community jar |