From: | Atira Odhner <aodhner(at)pivotal(dot)io> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Create screenshots when feature tests fail. |
Date: | 2017-03-15 15:14:12 |
Message-ID: | CA+Vc24qHgvYdEvEaE9Bt+yHpXxiZPsDTQ1i+F3bXq_b6d-Bw9g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hey Dave, looks like we missed the .keep file in the screenshots directory
when applying this patch.
It's making screenshots fail to be captured when the directory doesn't
exist (e.g. in CI).
On Thu, Mar 9, 2017 at 10:34 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Create screenshots when feature tests fail.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> d756f2f6c637e52951356948ad0c188f66689be6
> Author: Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io>
>
> Modified Files
> --------------
> .../connect_to_server_feature_test.py | 6 +-
> .../template_selection_feature_test.py | 6 +-
> .../settings/templates/settings/settings.js | 8 ++-
> web/regression/.gitignore | 1 +
> web/regression/feature_utils/base_feature_test.py | 73
> +++++++++++++++++++---
> web/regression/feature_utils/pgadmin_page.py | 13 +++-
> web/regression/test_utils.py | 2 +-
> 7 files changed, 87 insertions(+), 22 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
Attachment | Content-Type | Size |
---|---|---|
0001-ensure-the-screenshots-directory-exists.patch | application/octet-stream | 657 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Joao Pedro De Almeida Pereira | 2017-03-15 16:02:57 | [patch] Update Selenium and Chrome driver |
Previous Message | Atira Odhner | 2017-03-15 14:46:43 | Re: [patch] Refactor: clipboard, translations, jasmine |