Re: [patch] Refactor: clipboard, translations, jasmine

From: Atira Odhner <aodhner(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [patch] Refactor: clipboard, translations, jasmine
Date: 2017-03-15 14:46:43
Message-ID: CA+Vc24qCbBs3VN=39XBb=P1eiVx88cvmaVQWfL5djW8z9j6wxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Oops, somehow we ended up with package.json in the wrong directory! It
should be under web. Here is a patch to fix it. I also updated the readme
yarn/karma instructions.

Tira

On Wed, Mar 15, 2017 at 9:18 AM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:

> you could also try installing it with yarn.
>
> On Wed, Mar 15, 2017, 9:16 AM Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
>
>> Hmm. I'm not sure why you can't install karma-cli. Are you able to run
>> the tests using raw karma? (probably `web/node_modules/karma/bin/karma
>> start` )
>>
>> On Wed, Mar 15, 2017, 8:56 AM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Tue, Mar 14, 2017 at 8:16 PM, Atira Odhner <aodhner(at)pivotal(dot)io>
>>> wrote:
>>>
>>> Dave, try doing the yarn install and karma run from the web directory.
>>> karma cli expects karma to be under node_modules where it is run from.
>>> (which is where yarn will install it if you use yarn from the web
>>> directory). Karma also needs to be run from the directory where karma.conf
>>> is.
>>>
>>>
>>> Still no joy:
>>>
>>> piranha:pgadmin4 dpage$ cd web
>>> piranha:web dpage$ yarn
>>> yarn install v0.21.3
>>> info No lockfile found.
>>> [1/4] 🔍 Resolving packages...
>>> success Nothing to install.
>>> success Saved lockfile.
>>> ✨ Done in 0.28s.
>>> piranha:web dpage$ npm install -g karma-cli
>>> npm WARN checkPermissions Missing write access to
>>> /opt/local/lib/node_modules/karma-cli
>>> npm WARN checkPermissions Missing write access to
>>> /opt/local/lib/node_modules
>>> /opt/local/lib
>>> └── karma-cli(at)1(dot)0(dot)1
>>>
>>> npm ERR! Darwin 16.4.0
>>> npm ERR! argv "/opt/local/bin/node" "/opt/local/bin/npm" "install" "-g"
>>> "karma-cli"
>>> npm ERR! node v7.7.2
>>> npm ERR! npm v4.0.2
>>> npm ERR! path /opt/local/lib/node_modules/karma-cli
>>> npm ERR! code EACCES
>>> npm ERR! errno -13
>>> npm ERR! syscall access
>>>
>>> npm ERR! Error: EACCES: permission denied, access
>>> '/opt/local/lib/node_modules/karma-cli'
>>> npm ERR! { Error: EACCES: permission denied, access
>>> '/opt/local/lib/node_modules/karma-cli'
>>> npm ERR! errno: -13,
>>> npm ERR! code: 'EACCES',
>>> npm ERR! syscall: 'access',
>>> npm ERR! path: '/opt/local/lib/node_modules/karma-cli' }
>>> npm ERR!
>>> npm ERR! Please try running this command again as root/Administrator.
>>>
>>> npm ERR! Please include the following file with any support request:
>>> npm ERR! /Users/dpage/git/pgadmin4/web/npm-debug.log
>>> piranha:web dpage$ sudo npm install -g karma-cli
>>> Password:
>>> /opt/local/bin/karma -> /opt/local/lib/node_modules/karma-cli/bin/karma
>>> /opt/local/lib
>>> └── karma-cli(at)1(dot)0(dot)1
>>>
>>> piranha:web dpage$ karma start --single-run
>>> Cannot find local Karma!
>>> Please install Karma by `npm install karma --save-dev`.
>>> If you wanna use a global instance, please set NODE_PATH env variable.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>

Attachment Content-Type Size
0009-move-package.json-to-web-directory.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Atira Odhner 2017-03-15 15:14:12 Re: pgAdmin 4 commit: Create screenshots when feature tests fail.
Previous Message Atira Odhner 2017-03-15 13:18:30 Re: [patch] Refactor: clipboard, translations, jasmine