From: | Atira Odhner <aodhner(at)pivotal(dot)io> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Cc: | Joao Pedro De Almeida Pereira <jpereira(at)pivotal(dot)io> |
Subject: | [patch] Make feature test app teardown more reliable, and tests faster |
Date: | 2017-02-28 22:40:35 |
Message-ID: | CA+Vc24pqpVFJL-VNsk_CpGgGHBf6-EGNkcymXUTxHq5N96HQ-A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
We made the following improvements to the test suite:
Make feature test app teardown more reliable, and tests faster
- don't spin up app and chromedriver between each test
- catching signals also tears down the app
- do layout reset between tests, but assume that tests will not leave a
modal opened.
Use selenium built-in waiting function and fix flakiness around clicking
the alertify OK button
- we think the OK button does not have its event bound when it is
created.
If you see more flakiness around clicking the alertify OK button, let us
know. The element is clickable but we have to arbitrarily wait for the
event to be bound and that timing may vary system to system.
The feature tests are about 7 seconds faster now.
Tira & Joao
Attachment | Content-Type | Size |
---|---|---|
0001-Make-feature-test-app-teardown-more-reliable-and-tes.patch | application/octet-stream | 10.0 KB |
0002-Use-selenium-built-in-waiting-function-and-fix-flaki.patch | application/octet-stream | 6.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-03-01 10:03:46 | pgAdmin 4 commit: Ignore Visual Studio code editor files. |
Previous Message | Dave Page | 2017-02-28 17:09:42 | Re: [patch] Use TEST_SQLITE_PATH for tests |