Re: [patch] Make feature test app teardown more reliable, and tests faster

Awesome - thanks, patch applied.

On Tue, Feb 28, 2017 at 10:40 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
>
> Hi Hackers,
>
> We made the following improvements to the test suite:
>
> Make feature test app teardown more reliable, and tests faster
>
> - don't spin up app and chromedriver between each test
> - catching signals also tears down the app
> - do layout reset between tests, but assume that tests will not leave a
> modal opened.
>
> Use selenium built-in waiting function and fix flakiness around clicking
> the alertify OK button
>
> - we think the OK button does not have its event bound when it is
> created.
>
> If you see more flakiness around clicking the alertify OK button, let us
> know. The element is clickable but we have to arbitrarily wait for the event
> to be bound and that timing may vary system to system.
>
> The feature tests are about 7 seconds faster now.
>
> Tira & Joao
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company