From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Latch for the WAL writer - further reducing idle wake-ups. |
Date: | 2012-05-07 18:51:04 |
Message-ID: | CA+U5nMLvNOO7pMMXvy-nZugKmXNP7=ViKz0XE_mncdxeCQXTgg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 7 May 2012 19:44, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> On 7 May 2012 18:09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I also notice that the separate-checkpointer patch failed to rename
>>> assorted things like BgWriterCommLock, BgWriterRequest,
>>> BgWriterShmemStruct, which are all 100% inappropriately named now.
>>> And it still contains various obsolete comments referring to itself
>>> as the background writer. Will see about cleaning that up.
>
>> For want of a better name, keeping them the same seemed best.
>
> I was just thinking s/BgWriter/Checkpointer/, do you think that's too
> long?
CheckpointerCommLock
CheckpointerShmemStruct
work OK
CheckpointerRequest
sounds a little vague, but can be tweaked
It also leaves the situation that we have a catalog view called
pg_stat_bgwriter that would be accessing "checkpointer" things. That's
really the thorny one that I wasn't sure how to handle. Good example
of why we shouldn't expose internals too much.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-05-07 19:06:50 | Re: Latch for the WAL writer - further reducing idle wake-ups. |
Previous Message | Tom Lane | 2012-05-07 18:44:24 | Re: Latch for the WAL writer - further reducing idle wake-ups. |