From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |
Date: | 2014-03-18 14:00:34 |
Message-ID: | CA+U5nMKqjeohOZPn=TtF6gwLpvteoVKbNP9geEwoLiw158hQeQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 18 March 2014 13:51, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Tue, Mar 18, 2014 at 8:41 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> Perhaps we should consider a parameter for PGSharedMemoryDetach() ?
>
>> Yeah, maybe. It seems like a possible modularity violation, because
>> the PGSharedMemory... stuff has heretofore not needed to know anything
>> about DSM, and apart from this one function, it still wouldn't.
>
> That was exactly the reason we rejected that design upthread.
> PGSharedMemoryDetach is specific to the main shmem segment, and in fact
> has multiple OS-dependent implementations.
>
> You could make an argument for inventing some new wrapper function that
> calls both PGSharedMemoryDetach and dsm_detach_all, but I don't believe
> that the existing flavors of that function should know about DSM.
I'm not bothered which we choose, as long as its well documented to
ensure people that use those calls don't detach from just one when
they really would wish to detach from both.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-03-18 14:38:59 | pgsql: Fix pg_dumpall option parsing: -i doesn't take an argument. |
Previous Message | Tom Lane | 2014-03-18 13:51:42 | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-03-18 14:03:46 | Re: pg_archivecleanup bug |
Previous Message | Tom Lane | 2014-03-18 13:56:08 | Re: pg_archivecleanup bug |