| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_archivecleanup bug |
| Date: | 2014-03-18 13:56:08 |
| Message-ID: | 31842.1395150968@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Very good point. I have modified the patch to add this block in all
> cases where it was missing. I started to wonder about the comment and
> if the Mingw fix was released. Based on some research, I see this as
> fixed in mingw-runtime-3.2, released 2003-10-10. That's pretty old.
Yeah. I would vote for removing that code in all branches. There is no
reason to suppose somebody is going to install 8.4.22 on a machine that
they haven't updated mingw on since 2003. Or, if you prefer, just remove
it in HEAD --- but going around and *adding* more copies seems like
make-work. The fact that we've not heard complaints about the omissions
is good evidence that nobody's using the buggy mingw versions anymore.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-03-18 14:00:34 | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |
| Previous Message | Tom Lane | 2014-03-18 13:51:42 | Re: [COMMITTERS] pgsql: Make it easy to detach completely from shared memory. |