| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add isolation tests for DROP INDEX CONCURRENTLY. |
| Date: | 2012-10-18 14:24:18 |
| Message-ID: | CA+U5nMKijdKscHhxZ7COkvk0EiXhF0Cr32j+w=A2p-_=GYou2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 18 October 2012 14:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> Add isolation tests for DROP INDEX CONCURRENTLY.
>
> WTF? You just turned the whole buildfarm red. Didn't you read
> Abhijit's statement that the code fails these tests currently?
> Didn't you run the test before committing?
Yes, but I was expecting it to fail.
> Please revert, until we have patches in place that make these
> tests pass.
This was supposed to be two patches in quick succession, one to show
the bug and one to fix it, but another problem delayed the second
commit.
At your request, I will revert and do this in one.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2012-10-18 14:26:45 | pgsql: Revert tests for drop index concurrently. |
| Previous Message | Tom Lane | 2012-10-18 13:49:18 | Re: pgsql: Add isolation tests for DROP INDEX CONCURRENTLY. |