Re: pgsql: Add isolation tests for DROP INDEX CONCURRENTLY.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add isolation tests for DROP INDEX CONCURRENTLY.
Date: 2012-10-18 15:08:12
Message-ID: 27083.1350572892@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On 18 October 2012 14:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Please revert, until we have patches in place that make these
>> tests pass.

> This was supposed to be two patches in quick succession, one to show
> the bug and one to fix it, but another problem delayed the second
> commit.

FWIW, a reasonable way to handle that would have been to make two
(or more) commits locally, but not push until the final state was good.
Pushing known-broken code is an extremely unfriendly thing to do.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2012-10-18 15:23:59 pgsql: pg_dump: Output functions deterministically sorted
Previous Message Simon Riggs 2012-10-18 14:27:31 pgsql: Revert tests for drop index concurrently.