| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: btvacuumpage useless "orig_blkno" |
| Date: | 2011-11-21 22:11:21 |
| Message-ID: | CA+U5nMKJSbE-9qJO25QQ_6ns1ZEi=ww07eVm7bfPZQQRHngxFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 21, 2011 at 10:03 PM, Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I just noticed that btvacuumpage has two BlockNumber parameters -- blkno
> and orig_blkno. The only caller passes them as the same value; the
> header comments state that blkno would be different when recursing, but
> actually the function implements recursion internally by way of a cute
> "goto" trick. So it seems to me that the orig_blkno parameter is
> useless -- we could just remove it.
>
> Unless I'm completely missing something?
tail recursion - read comments at bottom of the function
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2011-11-21 22:19:13 | Re: btvacuumpage useless "orig_blkno" |
| Previous Message | Alvaro Herrera | 2011-11-21 22:03:59 | btvacuumpage useless "orig_blkno" |