| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | btvacuumpage useless "orig_blkno" |
| Date: | 2011-11-21 22:03:59 |
| Message-ID: | 1321912069-sup-456@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I just noticed that btvacuumpage has two BlockNumber parameters -- blkno
and orig_blkno. The only caller passes them as the same value; the
header comments state that blkno would be different when recursing, but
actually the function implements recursion internally by way of a cute
"goto" trick. So it seems to me that the orig_blkno parameter is
useless -- we could just remove it.
Unless I'm completely missing something?
--
Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
| Attachment | Content-Type | Size |
|---|---|---|
| btvacuumscan.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-11-21 22:11:21 | Re: btvacuumpage useless "orig_blkno" |
| Previous Message | Josh Berkus | 2011-11-21 20:49:01 | Writeable FDWs? |