| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tarvip(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #7710: Xid epoch is not updated properly during checkpoint |
| Date: | 2012-12-02 10:12:53 |
| Message-ID: | CA+U5nMKFZ7E_5YO2w4=Cs4p41tEpJEjyrz8suuLuS21-8aXdqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 1 December 2012 23:10, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> So barring objections, I'm going to remove LogStandbySnapshot's behavior
>> of returning the updated nextXid.
>
> I don't see any reason why it would be bad to remove this. I think the
> current behaviour could actually even delay getting to an active state
> slightly in the presence of prepared transactions because its used to
> create to initialize the KnownAssignedXid machinery in xlog_redo. If the
> prepared xacts are suboverflown its a *good* thing to have an old
> ->nextXid.
That particular coding was pretty weird. Please change.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2012-12-02 12:51:57 | Re: BUG #7710: Xid epoch is not updated properly during checkpoint |
| Previous Message | Andres Freund | 2012-12-01 23:49:08 | Re: BUG #7710: Xid epoch is not updated properly during checkpoint |