Re: BUG #7710: Xid epoch is not updated properly during checkpoint

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: tarvip(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: BUG #7710: Xid epoch is not updated properly during checkpoint
Date: 2012-12-01 23:49:08
Message-ID: 20121201234908.GA24090@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2012-12-02 00:10:22 +0100, Andres Freund wrote:
> On 2012-12-01 17:56:33 -0500, Tom Lane wrote:
> > So barring objections, I'm going to remove LogStandbySnapshot's behavior
> > of returning the updated nextXid.
>
> I don't see any reason why it would be bad to remove this. I think the
> current behaviour could actually even delay getting to an active state
> slightly in the presence of prepared transactions because its used to
> create to initialize the KnownAssignedXid machinery in xlog_redo. If the
> prepared xacts are suboverflown its a *good* thing to have an old
> ->nextXid.

That doesn't hold true btw, due to the fact LogStandbySnapshot isn't
called in the shutdown case.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Simon Riggs 2012-12-02 10:12:53 Re: BUG #7710: Xid epoch is not updated properly during checkpoint
Previous Message Andres Freund 2012-12-01 23:10:22 Re: BUG #7710: Xid epoch is not updated properly during checkpoint