| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Date: | 2014-11-18 11:57:47 |
| Message-ID: | CA+U5nMJT+3-4Ph52yYo8cQ37AXpHUuidsOXtc0TMySAU-GYzwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31 October 2014 15:18, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> Attached is the v2 of the patch with the review comments addressed (see
> below).
...
> Done, there is now action_at_recovery_target which can be set to either
> pause, continue or shutdown, defaulting to pause (which is same as old
> behavior of pause_at_recovery_target defaulting to true).
One comment only: I think the actions should be called: pause, promote
and shutdown, since "continue" leads immediately to promotion of the
server.
I'm good with this patch otherwise. Barring objections I will commit tomorrow.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-11-18 12:09:04 | Re: [TODO] Track number of files ready to be archived in pg_stat_archiver |
| Previous Message | Jeff Davis | 2014-11-18 09:40:35 | Re: group locking: incomplete patch, just for discussion |