From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add shutdown_at_recovery_target option to recovery.conf |
Date: | 2014-11-18 22:05:14 |
Message-ID: | 546BC29A.5060402@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 18/11/14 12:57, Simon Riggs wrote:
> On 31 October 2014 15:18, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>
>> Attached is the v2 of the patch with the review comments addressed (see
>> below).
> ...
>> Done, there is now action_at_recovery_target which can be set to either
>> pause, continue or shutdown, defaulting to pause (which is same as old
>> behavior of pause_at_recovery_target defaulting to true).
>
> One comment only: I think the actions should be called: pause, promote
> and shutdown, since "continue" leads immediately to promotion of the
> server.
>
> I'm good with this patch otherwise. Barring objections I will commit tomorrow.
>
OK, promote works for me as well, I attached patch that changes continue
to promote so you don't have to find and replace everything yourself.
The changed doc wording probably needs to be checked.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
shutdown_at_recovery_target-v3.patch | text/x-diff | 7.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2014-11-18 22:14:55 | Re: New Event Trigger: table_rewrite |
Previous Message | Peter Geoghegan | 2014-11-18 22:01:13 | Re: GIN pageinspect functions |