Re: Substituting Checksum Algorithm (was: Enabling Checksums)

On 26 April 2013 14:40, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>>> On 2013-04-26 13:11:00 +0200, Florian Pflug wrote:
>>>> The unresolved code issue that I know of is moving the compiler flags behind a configure check. I would greatly appreciate it if you could take a look at that. My config-fu is weak and it would take me some time to figure out how to do that.
>
>>> Do we necessarily have to do that before beta? If not, let's concentrate on getting the basic path in, and let's add the gcc-specific compiler options later.
>
>> If we want them we should do it before beta, otherwise we won't notice
>> problems that the flags cause (misoptimizations, problems on compiler
>> versions, ...). So either now or in 9.4.
>
> Yeah, beta1 is the point in the cycle where we have the most leverage
> for discovering portability problems. We should not be leaving anything
> involving configure tests as "to fix later".

I'm expecting to spend some time on this over the weekend, once I've
re-read the thread and patches to see if there is something to commit.

That's my last time window, so this looks like the last chance to make
changes before beta.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services