| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with pg_upgrade's directory write check on Windows |
| Date: | 2011-07-23 13:19:32 |
| Message-ID: | CA+TgmobXrxWqE5tsY_iEY-Un3eb8v-MsJ1ENtPsffpLRxk2cbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 23, 2011 at 9:14 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Andrew Dunstan wrote:
>> > We do use access() in a few other places in our code, but not for
>> > directory permission checks.
>> >
>> > Any ideas on a solution? Will checking stat() work? Do I have to try
>> > creating a dummy file and delete it?
>>
>> That looks like the obvious solution - it's what came to my mind even
>> before reading this sentence.
>
> Well, the easy fix is to see if ALL_DUMP_FILE
> ("pg_upgrade_dump_all.sql") exists, and if so remove it, and if not,
> create it and remove it.
>
> Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? The
> check works fine on non-Windows.
Seems worth back-patching to me.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-07-23 14:42:36 | Re: Questions and experiences writing a Foreign Data Wrapper |
| Previous Message | Bruce Momjian | 2011-07-23 13:14:21 | Re: Problem with pg_upgrade's directory write check on Windows |