| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Problem with pg_upgrade's directory write check on Windows |
| Date: | 2011-07-23 13:14:21 |
| Message-ID: | 201107231314.p6NDELc27882@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
> > We do use access() in a few other places in our code, but not for
> > directory permission checks.
> >
> > Any ideas on a solution? Will checking stat() work? Do I have to try
> > creating a dummy file and delete it?
>
> That looks like the obvious solution - it's what came to my mind even
> before reading this sentence.
Well, the easy fix is to see if ALL_DUMP_FILE
("pg_upgrade_dump_all.sql") exists, and if so remove it, and if not,
create it and remove it.
Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? The
check works fine on non-Windows.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-07-23 13:19:32 | Re: Problem with pg_upgrade's directory write check on Windows |
| Previous Message | Andrew Dunstan | 2011-07-23 12:57:34 | Re: Problem with pg_upgrade's directory write check on Windows |