| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Breakage with VACUUM ANALYSE + partitions |
| Date: | 2016-04-12 13:00:57 |
| Message-ID: | CA+TgmobNCZ_uZhO-mo4ArKWNGyoe8bY+Gvy7egHVSzHMqoiL5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Apr 11, 2016 at 1:17 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I can think of a number of relatively easy ways to address this:
> 1) Just zap (or issue?) all pending flush requests when getting an
> smgrinval/smgrclosenode
> 2) Do 1), but filter for the closed relnode
> 3) Actually handle the case of the last open segment not being
> RELSEG_SIZE properly in _mdfd_getseg() - mdnblocks() does so.
>
> I'm kind of inclined to do both 3) and 1).
#3 seems like it's probably about 15 years overdue, so let's do that anyway.
I don't quite understand why #1 fixes the problem - not because I
doubt you, but just because I haven't studied it much.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-04-12 15:18:32 | Repeated requests for feedback in logical standby |
| Previous Message | Fabien COELHO | 2016-04-12 08:51:49 | Re: [HACKERS] Breakage with VACUUM ANALYSE + partitions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2016-04-12 13:09:05 | Re: Some other things about contrib/bloom and generic_xlog.c |
| Previous Message | Robert Haas | 2016-04-12 12:53:56 | Re: Choosing parallel_degree |