| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Breakage with VACUUM ANALYSE + partitions |
| Date: | 2016-04-16 22:23:01 |
| Message-ID: | 20160416222301.GA1913058@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Tue, Apr 12, 2016 at 09:00:57AM -0400, Robert Haas wrote:
> On Mon, Apr 11, 2016 at 1:17 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I can think of a number of relatively easy ways to address this:
> > 1) Just zap (or issue?) all pending flush requests when getting an
> > smgrinval/smgrclosenode
> > 2) Do 1), but filter for the closed relnode
> > 3) Actually handle the case of the last open segment not being
> > RELSEG_SIZE properly in _mdfd_getseg() - mdnblocks() does so.
> >
> > I'm kind of inclined to do both 3) and 1).
Andres, you own the underlying open item, right? Do you plan to implement
this fix you have outlined? If so, when?
> #3 seems like it's probably about 15 years overdue, so let's do that anyway.
>
> I don't quite understand why #1 fixes the problem - not because I
> doubt you, but just because I haven't studied it much.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-04-16 22:28:23 | Re: Breakage with VACUUM ANALYSE + partitions |
| Previous Message | soufiane.boussali | 2016-04-16 11:38:05 | BUG #14090: Some installations of Postgres 8 and 9 are configured to allow loading external scripting languages. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-16 22:27:06 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Previous Message | Andres Freund | 2016-04-16 22:04:39 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |