From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | some additional (small) problems with pg_combinebackup and tablespaces |
Date: | 2024-04-24 17:59:33 |
Message-ID: | CA+TgmobFBUW5ATRb1E7OvDD_zbSGFm0pX3i-H0be3FbiDmgihQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tomas Vondra pointed out to me a couple of mistakes that I made with
regard to pg_combinebackup and tablespaces.
One is that I screwed up the long_options array by specifying
tablespace-mapping as no_argument rather than required_argument. That
doesn't break the tests I just committed because, in the actual string
passed to getopt_long(), I wrote "T:", which means the short form of
the option works; only the long form does not.
The other is that the documentation says that --tablespace-mapping is
applied to the pathnames from the first backup specified on the
command line. It should have said "final" rather than "first".
Here is a very small patch correcting these regrettable errors.
--
Robert Haas
EDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Fix-small-mistakes-around-pg_combinebackup-with-t.patch | application/octet-stream | 2.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-04-24 19:08:27 | Re: Add notes to pg_combinebackup docs |
Previous Message | Jacob Champion | 2024-04-24 17:55:29 | Re: Row pattern recognition |