Re: some additional (small) problems with pg_combinebackup and tablespaces

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: some additional (small) problems with pg_combinebackup and tablespaces
Date: 2024-04-24 19:19:57
Message-ID: 13731EBE-08AC-4EA5-B655-F8B7E5149964@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Apr 2024, at 19:59, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Here is a very small patch correcting these regrettable errors.

Patch LGTM.

In addition to those, unless I'm reading it wrong the current coding seems to
include a "-P" short option which is missing in the command parsing switch
statement (or in the help output):

while ((c = getopt_long(argc, argv, "dnNPo:T:",

Should that be removed?

A tiny nit-pick in the same area: while not wrong, it reads a bit odd to have
"don't" and "do not" on lines directly next to each other:

printf(_(" -n, --dry-run don't actually do anything\n"));
printf(_(" -N, --no-sync do not wait for changes to be written safely to disk\n"));

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2024-04-24 19:22:03 Re: Q: Escapes in jsonpath Idents
Previous Message Melanie Plageman 2024-04-24 19:10:27 Re: New GUC autovacuum_max_threshold ?