Re: Re: [GENERAL] pg_dump behaves differently for different archive formats

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [GENERAL] pg_dump behaves differently for different archive formats
Date: 2014-07-29 16:35:35
Message-ID: CA+TgmobB2yPwV-ea0voOkuGz_mDs7gWEOZtYBnB7b_-yEMqXpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Mon, Jul 28, 2014 at 10:55 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> If we're going to change this, it seems to me that the only option would
>> be to change the dump format... Just off-the-cuff, I'm wondering if we
>> could actually not change the real 'format' but simply promote each ACL
>> entry (and similar cases..) to top-level objects and declare that TOC
>> entries should be single statements.
>
> I don't think we want even more TOC entries, but it would not be
> unreasonable to insist that the statement(s) within a TOC entry be
> subdivided somehow. Essentially the payload of a TOC entry becomes
> a list of strings rather than just one string.
>
> That would mean that the problem could not be fixed for existing archive
> files; but that seems OK, given the rather small number of complaints
> so far.
>
> If we had something like that, I'd be strongly inclined to get rid of
> the existing convention whereby comments and ACL commands are separate
> TOC entries, and make them part of the parent object's TOC entry (which'd
> mean we'd want to label the sub-strings so we can tell whether they are
> main object, comment, or ACL). The fewer TOC entries we can have, the
> better; there is no reason why comments/ACLs should be independently
> sortable.

Maybe, but I think people will still want an option to skip restoring
them altogether (at least for ACLs).

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2014-07-29 16:38:16 Re: Re: [GENERAL] pg_dump behaves differently for different archive formats
Previous Message Bror Jonsson 2014-07-29 16:31:38 Problems with pg_upgrade.

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2014-07-29 16:35:46 Re: Proposal: Incremental Backup
Previous Message Marco Nenciarini 2014-07-29 16:24:12 Re: Proposal: Incremental Backup