| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.] |
| Date: | 2022-04-07 15:19:15 |
| Message-ID: | CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 5, 2022 at 10:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> What I think you need to do is:
>
> 1. In the back branches, revert delayChkpt to its previous type and
> semantics. Squeeze a separate delayChkptEnd bool in somewhere
> (you can't change the struct size either ...).
>
> 2. In HEAD, rename the field to something like delayChkptFlags,
> to ensure that any code touching it has to be inspected and updated.
Here are patches for master and v14 to do things this way. Comments?
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-delayChkpt-to-delayChkptFlags.patch | application/octet-stream | 15.9 KB |
| 0001-Rethink-the-delay-checkpoint-end-mechanism-in-the-ba.patch | application/octet-stream | 16.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2022-04-07 15:45:24 | pgsql: Fix another buildfarm issue from commit 5c279a6d350. |
| Previous Message | Peter Eisentraut | 2022-04-07 14:24:42 | pgsql: Unlogged sequences |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-04-07 15:24:38 | Re: unlogged sequences |
| Previous Message | Josef Šimánek | 2022-04-07 15:15:24 | Re: How about a psql backslash command to show GUCs? |