| From: | Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.] |
| Date: | 2022-04-07 18:07:17 |
| Message-ID: | 051E2C40-14DF-4AE4-9273-A9A42CDAB5C2@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> On 7. 4. 2022, at 17:19, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Apr 5, 2022 at 10:17 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> What I think you need to do is:
>>
>> 1. In the back branches, revert delayChkpt to its previous type and
>> semantics. Squeeze a separate delayChkptEnd bool in somewhere
>> (you can't change the struct size either ...).
>>
>> 2. In HEAD, rename the field to something like delayChkptFlags,
>> to ensure that any code touching it has to be inspected and updated.
>
> Here are patches for master and v14 to do things this way. Comments?
Yeah I think this should do it (compilers should warn on master even without the rename, but who notices that right? :) )
Thanks,
Petr
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-04-07 18:12:02 | Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |
| Previous Message | Tom Lane | 2022-04-07 17:57:45 | Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-04-07 18:12:02 | Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |
| Previous Message | Andres Freund | 2022-04-07 18:02:41 | Re: test/isolation/expected/stats_1.out broken for me |