Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, steven(dot)winfield(at)cantabcapital(dot)com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
Date: 2019-12-11 14:17:35
Message-ID: CA+Tgmoajh2XZ3Z8o6p7mftsfK5owqy3F5o05rNaAW==rF90+tQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Sun, Nov 3, 2019 at 5:40 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Of course, this only works if we have those hooks :-(. So far as
> I can tell, all libreadline variants that might still exist in the wild
> do have them; but libedit doesn't, at least not in the version Apple
> is shipping. Hence, what the attached patch does is to make configure
> probe for the existence of the hook variables; if they're not there,
> fall back to what I proposed previously.

Are people still compiling against libedit and then redirecting to
libreadline at runtime? I seem to recall some discussion about this
being a thing, many years ago. If it were being done it would be
advantageous to have the checks be runtime rather than compile-time,
although I guess that would probably be tough to make work.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tomas Vondra 2019-12-11 14:23:10 Re: Memory leak (possibly connected to postgis) leading to server crash
Previous Message PG Bug reporting form 2019-12-11 12:39:20 BUG #16159: recovery requests WALs for the next timelines before timeline switch LSN has been reached

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-12-11 14:28:01 Re: VACUUM memory management
Previous Message Robert Haas 2019-12-11 14:12:49 Re: global / super barriers (for checksums)