From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, steven(dot)winfield(at)cantabcapital(dot)com |
Subject: | Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes |
Date: | 2019-12-11 15:06:37 |
Message-ID: | 20191211150637.GA21159@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On 2019-Dec-11, Robert Haas wrote:
> On Sun, Nov 3, 2019 at 5:40 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Of course, this only works if we have those hooks :-(. So far as
> > I can tell, all libreadline variants that might still exist in the wild
> > do have them; but libedit doesn't, at least not in the version Apple
> > is shipping. Hence, what the attached patch does is to make configure
> > probe for the existence of the hook variables; if they're not there,
> > fall back to what I proposed previously.
>
> Are people still compiling against libedit and then redirecting to
> libreadline at runtime? I seem to recall some discussion about this
> being a thing, many years ago.
Yeah, Debian did that out of licensing concerns. It seems they still do
that, based on
https://packages.debian.org/bullseye/postgresql-client-12
> If it were being done it would be
> advantageous to have the checks be runtime rather than compile-time,
> although I guess that would probably be tough to make work.
Yeah. On the other hand, I suppose Debian uses the BSD version of the
libraries, not the Apple version, so I think it should be fine?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-12-11 15:18:35 | Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes |
Previous Message | Tomas Vondra | 2019-12-11 14:23:10 | Re: Memory leak (possibly connected to postgis) leading to server crash |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2019-12-11 15:16:29 | Re: Fetching timeline during recovery |
Previous Message | Robert Haas | 2019-12-11 15:05:00 | Re: allowing broader use of simplehash |