Re: parallel.c is not marked as test covered

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Clément Prévost <prevostclement(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel.c is not marked as test covered
Date: 2016-06-10 20:12:48
Message-ID: CA+Tgmoac+sysZi0QKtexCKwQ99fjiwfrbQJ4aom-i1C0s6SeAg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 10, 2016 at 1:49 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Regarding the patch that ended up being committed, I wonder if it is
> intentional that PL/pgSQL overwrites the context from the parallel worker.
> Shouldn't the context effectively look like
>
> ERROR: message
> CONTEXT: parallel worker
> CONTEXT: PL/pgSQL function
>
> Elsewhere in this thread I suggested getting rid of the parallel worker
> context by default (except for debugging), but if we do want to keep it,
> then it seems to be a bug that a PL/pgSQL function can just eliminate it.

Several people have suggested getting rid of that now, so maybe we
should just go ahead and do it.

How would we make it available for debugging, though? That seems like
something people will want.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-06-10 20:14:03 Re: [sqlsmith] Failed assertion in postgres_fdw/deparse.c:1116
Previous Message Robert Haas 2016-06-10 19:54:10 Re: Reviewing freeze map code