| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com>, Clément Prévost <prevostclement(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: parallel.c is not marked as test covered |
| Date: | 2016-06-10 17:49:35 |
| Message-ID: | 58cd047c-deba-0863-b279-56b931237176@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/7/16 11:43 PM, Noah Misch wrote:
> I changed this to keep the main message while overwriting the CONTEXT; a bug
> in this area could very well produce some other error rather than no error.
Regarding the patch that ended up being committed, I wonder if it is
intentional that PL/pgSQL overwrites the context from the parallel
worker. Shouldn't the context effectively look like
ERROR: message
CONTEXT: parallel worker
CONTEXT: PL/pgSQL function
Elsewhere in this thread I suggested getting rid of the parallel worker
context by default (except for debugging), but if we do want to keep it,
then it seems to be a bug that a PL/pgSQL function can just eliminate it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-06-10 17:59:11 | Re: Reviewing freeze map code |
| Previous Message | Robert Haas | 2016-06-10 17:43:41 | Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted |