Re: logical changeset generation v6.8

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: logical changeset generation v6.8
Date: 2013-12-11 18:45:51
Message-ID: CA+TgmoaNu5Msp7o_fxHqSEGoL1vCb_h6mHok85mjsSOb8NsCEw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 11, 2013 at 11:25 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2013-12-10 19:11:03 -0500, Robert Haas wrote:
>> Committed #1 (again). Regarding this:
>>
>> + /* XXX: we could also do this unconditionally, the space is used anyway
>> + if (copy_oid)
>> + HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp));
>>
>> I would like to put in a big +1 for doing that unconditionally. I
>> didn't make that change before committing, but I think it'd be a very
>> good idea.
>
> Patch attached.

Committed with kibitzing.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-12-11 18:47:48 Re: -d option for pg_isready is broken
Previous Message Fabrízio de Royes Mello 2013-12-11 18:37:54 Re: Time-Delayed Standbys