From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: logical changeset generation v6.8 |
Date: | 2013-12-11 16:25:31 |
Message-ID: | 20131211162531.GE25227@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2013-12-10 19:11:03 -0500, Robert Haas wrote:
> Committed #1 (again). Regarding this:
>
> + /* XXX: we could also do this unconditionally, the space is used anyway
> + if (copy_oid)
> + HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp));
>
> I would like to put in a big +1 for doing that unconditionally. I
> didn't make that change before committing, but I think it'd be a very
> good idea.
Patch attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Dep-t-of-second-thoughts-Always-include-oids-in-WAL-.patch | text/x-patch | 2.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | knizhnik | 2013-12-11 16:25:33 | Re: In-Memory Columnar Store |
Previous Message | Tom Lane | 2013-12-11 16:24:01 | Re: -d option for pg_isready is broken |