Re: pgsql: Fix minor problems with non-exclusive backup cleanup.

On Thu, Aug 6, 2020 at 2:19 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
> > Fix minor problems with non-exclusive backup cleanup.
>
> Seems like there's an extra space in this error message in
> do_pg_abort_backup:
>
> + if (emit_warning)
> + ereport(WARNING,
> + (errmsg("aborting backup due to backend exiting before pg_stop_back up was called")));

Ah, crap. Peter fixed that before, and I forgot to include it when
back-patching.

> Also, while I'm bugging you: it wasn't quite clear from the thread
> whether this is alone sufficient to fix the user-visible issue
> reported by Bharath Rupireddy, or whether we still need to change
> the JIT logic as well to do that.

I believe it suffices, but see also the commit I pushed to master.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company